( )⚙ D2174 py3: convert context to bytes instead of str

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2174

py3: convert context to bytes instead of str
ClosedPublic

Authored by indygreg on Feb 11 2018, 10:45 PM.

Details

Reviewers
pulkit
durin42
Group Reviewers
hg-reviewers
Commits
rHG8eb13f5d5d3f: py3: convert context to bytes instead of str
rHGdd905ea1ea60: py3: convert context to bytes instead of str
Summary

This yields identical behavior on Python 2 and 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 10:45 PM
pulkit accepted this revision.Feb 12 2018, 2:49 AM
durin42 accepted this revision.Feb 12 2018, 9:33 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:33 PM
Closed by commit rHGdd905ea1ea60: py3: convert context to bytes instead of str (authored by indygreg). · Explain WhyFeb 12 2018, 9:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/debugcommands.py (2 lines)

Diff 5597

mercurial/debugcommands.py

<successors-2B1> <successors-2B2> <successors-2B3> <successors-2B1> <successors-2B2> <successors-2B3>
Here rev2 has two possible (i.e. divergent) successors sets. The first Here rev2 has two possible (i.e. divergent) successors sets. The first
holds one element, whereas the second holds three (i.e. the changeset has holds one element, whereas the second holds three (i.e. the changeset has
been split). been split).
""" """
# passed to successorssets caching computation from one call to another # passed to successorssets caching computation from one call to another
cache = {} cache = {}
ctx2str = str ctx2str = bytes
node2str = short node2str = short
for rev in scmutil.revrange(repo, revs): for rev in scmutil.revrange(repo, revs):
ctx = repo[rev] ctx = repo[rev]
ui.write('%s\n'% ctx2str(ctx)) ui.write('%s\n'% ctx2str(ctx))
for succsset in obsutil.successorssets(repo, ctx.node(), for succsset in obsutil.successorssets(repo, ctx.node(),
closest=opts[r'closest'], closest=opts[r'closest'],
cache=cache): cache=cache):
if succsset: if succsset: