This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2175

py3: use b'' in mockblackbox.py
ClosedPublic

Authored by indygreg on Feb 11 2018, 10:45 PM.

Details

Reviewers
pulkit
durin42
Group Reviewers
hg-reviewers
Commits
rHGf49c3ee5b02f: py3: use b'' in mockblackbox.py
Summary

This unmasks a ton of other TypeError in blackbox code.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 10:45 PM
pulkit accepted this revision.Feb 12 2018, 2:50 AM
pulkit added a subscriber: pulkit.

This one needs # skip-blame in commit message.

durin42 accepted this revision.Feb 12 2018, 9:25 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:25 PM
Closed by commit rHGf49c3ee5b02f: py3: use b'' in mockblackbox.py (authored by indygreg). · Explain WhyFeb 12 2018, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/mockblackbox.py (2 lines)

Diff 5576

tests/mockblackbox.py

from __future__ import absolute_import from __future__ import absolute_import
from mercurial import ( from mercurial import (
util, util,
) )
# XXX: we should probably offer a devel option to do this in blackbox directly # XXX: we should probably offer a devel option to do this in blackbox directly
def getuser(): def getuser():
return 'bob' return b'bob'
def getpid(): def getpid():
return 5000 return 5000
# mock the date and user apis so the output is always the same # mock the date and user apis so the output is always the same
def uisetup(ui): def uisetup(ui):
util.getuser = getuser util.getuser = getuser
util.getpid = getpid util.getpid = getpid