This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2176

py3: convert traceback representation to bytes when logging
ClosedPublic

Authored by indygreg on Feb 11 2018, 10:45 PM.

Details

Reviewers
pulkit
durin42
Group Reviewers
hg-reviewers
Commits
rHG976a9fd706ed: py3: convert traceback representation to bytes when logging
rHG9446246e4d1a: py3: convert traceback representation to bytes when logging
Summary

Python's APIs should return a system string. We want to use bytes
for logging. So convert the traceback to bytes before sending
it to the logger.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 10:45 PM
pulkit accepted this revision.Feb 12 2018, 2:51 AM
durin42 accepted this revision.Feb 12 2018, 9:33 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:33 PM
Closed by commit rHG9446246e4d1a: py3: convert traceback representation to bytes when logging (authored by indygreg). · Explain WhyFeb 12 2018, 9:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dispatch.py (3 lines)

Diff 5598

mercurial/dispatch.py

def handlecommandexception(ui): def handlecommandexception(ui):
"""Produce a warning message for broken commands """Produce a warning message for broken commands
Called when handling an exception; the exception is reraised if Called when handling an exception; the exception is reraised if
this function returns False, ignored otherwise. this function returns False, ignored otherwise.
""" """
warning = _exceptionwarning(ui) warning = _exceptionwarning(ui)
ui.log("commandexception", "%s\n%s\n", warning, traceback.format_exc()) ui.log("commandexception", "%s\n%s\n", warning,
pycompat.sysbytes(traceback.format_exc()))
ui.warn(warning) ui.warn(warning)
return False # re-raise the exception return False # re-raise the exception