( )⚙ D7395 uncommit: use field names instead of field numbers on scmutil.status

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7395

uncommit: use field names instead of field numbers on scmutil.status
ClosedPublic

Authored by durin42 on Nov 14 2019, 4:08 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGd0310f21ee9e: uncommit: use field names instead of field numbers on scmutil.status
Summary

As part of my pytype adventures I want to make scmutil.status no longer a
subclass of tuple. This is part of that process.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 14 2019, 4:08 PM
indygreg accepted this revision.Nov 14 2019, 10:23 PM
indygreg added a subscriber: indygreg.

I weep every time I see single letter variables. But it isn't your fault.

This revision is now accepted and ready to land.Nov 14 2019, 10:23 PM

Revision Contents
Changeset List

PathPackages
Mhgext/uncommit.py (3 lines)

Diff 18085

hgext/uncommit.py

""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
cmdutil.checknotesize(ui, opts) cmdutil.checknotesize(ui, opts)
cmdutil.resolvecommitoptions(ui, opts) cmdutil.resolvecommitoptions(ui, opts)
with repo.wlock(), repo.lock(): with repo.wlock(), repo.lock():
m, a, r, d = repo.status()[:4] st = repo.status()
m, a, r, d = st.modified, st.added, st.removed, st.deleted
isdirtypath = any(set(m + a + r + d) & set(pats)) isdirtypath = any(set(m + a + r + d) & set(pats))
allowdirtywcopy = opts[ allowdirtywcopy = opts[
b'allow_dirty_working_copy' b'allow_dirty_working_copy'
] or repo.ui.configbool(b'experimental', b'uncommitondirtywdir') ] or repo.ui.configbool(b'experimental', b'uncommitondirtywdir')
if not allowdirtywcopy and (not pats or isdirtypath): if not allowdirtywcopy and (not pats or isdirtypath):
cmdutil.bailifchanged( cmdutil.bailifchanged(
repo, repo,
hint=_(b'requires --allow-dirty-working-copy to uncommit'), hint=_(b'requires --allow-dirty-working-copy to uncommit'),