This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7398

commands: use field names instead of field numbers on scmutil.status
ClosedPublic

Authored by durin42 on Nov 14 2019, 4:09 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG1e1bad31b427: commands: use field names instead of field numbers on scmutil.status
Summary

As part of my pytype adventures I want to make scmutil.status no longer a
subclass of tuple. This is part of that process.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (10 lines)

Diff 18126

mercurial/commands.py

editor=editor, editor=editor,
extra=extra, extra=extra,
) )
node = cmdutil.commit(ui, repo, commitfunc, pats, opts) node = cmdutil.commit(ui, repo, commitfunc, pats, opts)
if not node: if not node:
stat = cmdutil.postcommitstatus(repo, pats, opts) stat = cmdutil.postcommitstatus(repo, pats, opts)
if stat[3]: if stat.deleted:
ui.status( ui.status(
_( _(
b"nothing changed (%d missing files, see " b"nothing changed (%d missing files, see "
b"'hg status')\n" b"'hg status')\n"
) )
% len(stat[3]) % len(stat.deleted)
) )
else: else:
ui.status(_(b"nothing changed\n")) ui.status(_(b"nothing changed\n"))
return 1 return 1
cmdutil.commitstatus(repo, node, branch, bheads, opts) cmdutil.commitstatus(repo, node, branch, bheads, opts)
if not ui.quiet and ui.configbool(b'commands', b'commit.post-status'): if not ui.quiet and ui.configbool(b'commands', b'commit.post-status'):
ctx2.node(), ctx2.node(),
m, m,
b'ignored' in show, b'ignored' in show,
b'clean' in show, b'clean' in show,
b'unknown' in show, b'unknown' in show,
opts.get(b'subrepos'), opts.get(b'subrepos'),
) )
changestates = zip(states, pycompat.iterbytestr(b'MAR!?IC'), stat) changestates = zip(
states,
pycompat.iterbytestr(b'MAR!?IC'),
[getattr(stat, s.decode('utf8')) for s in states],
)
copy = {} copy = {}
if ( if (
opts.get(b'all') opts.get(b'all')
or opts.get(b'copies') or opts.get(b'copies')
or ui.configbool(b'ui', b'statuscopies') or ui.configbool(b'ui', b'statuscopies')
) and not opts.get(b'no_status'): ) and not opts.get(b'no_status'):
copy = copies.pathcopies(ctx1, ctx2, m) copy = copies.pathcopies(ctx1, ctx2, m)