( )⚙ D12318 global: bulk replace simple pycompat.iteritems(x) with x.items()

This is an archive of the discontinued Mercurial Phabricator instance.

global: bulk replace simple pycompat.iteritems(x) with x.items()

Authored by indygreg on Mar 3 2022, 4:21 PM.



pycompat.iteritems() just calls .items().

This commit applies a regular expression search and replace to convert
simple instances of pycompat.iteritems() with .items(). There are still
a handful of calls to pycompat.iteritems() remaining. But these all have
more complicated expressions that I wasn't comfortable performing an
automated replace on. In addition, some simple replacements were withheld
because they broke pytype. These will be handled by their own changesets.

Diff Detail

rHG Mercurial
No Linters Available
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 3 2022, 4:21 PM
indygreg edited the summary of this revision. (Show Details)Mar 3 2022, 9:31 PM
indygreg updated this revision to Diff 32549.
Alphare accepted this revision.Mar 8 2022, 4:24 AM
This revision is now accepted and ready to land.Mar 8 2022, 4:24 AM