wireproto: define content negotiation for HTTPv2
ClosedPublic

Authored by indygreg on Mar 13 2018, 9:16 PM.

Download Raw Diff

Details

Reviewers

durin42

Group Reviewers

hg-reviewers

Commits

rHG37d7a1d18b97: wireproto: define content negotiation for HTTPv2

Summary

HTTP messages communicate their media types and what media types
they can understand via the Content-Type and Accept header,
respectively.

While I don't want the wire protocol to lean too heavily on HTTP
because I'm aiming for the wire protocol to be as transport
agnostic as possible, it is nice to play by the spec if possible.

This commit defines our media negotiation mechanism for version
2 of the HTTP protocol. Essentially, we mandate the use of a
new media type and how clients and servers should react to
various headers or lack thereof.

The name of the media type is a placeholder. We purposefully don't
yet define the format of the new media type because that's a lot
of work.

I feel pretty strongly that we should use Content-Type. I feel
less strongly about Accept. I think it is reasonable for servers
to return the media type that was submitted to them. So we may
strike this header before the protocol is finished...

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 13 2018, 9:16 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptMar 13 2018, 9:16 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

indygreg added a child revision: D2851: wireproto: define and implement protocol for issuing requests.Mar 13 2018, 10:49 PM

indygreg updated this revision to Diff 7016.

indygreg added a child revision: D2868: util: prefer "bytesio" to "stringio".Mar 14 2018, 9:11 PM

indygreg removed a child revision: D2851: wireproto: define and implement protocol for issuing requests.

indygreg updated this revision to Diff 7138.Mar 19 2018, 7:59 PM

durin42 accepted this revision.Mar 21 2018, 3:18 PM

This revision is now accepted and ready to land.Mar 21 2018, 3:18 PM

indygreg updated this revision to Diff 7198.Mar 21 2018, 6:19 PM

durin42 accepted this revision.Mar 21 2018, 6:22 PM

Closed by commit rHG37d7a1d18b97: wireproto: define content negotiation for HTTPv2 (authored by indygreg). · Explain WhyMar 21 2018, 8:58 PM

This revision was automatically updated to reflect the committed changes.

We might have to handle multiple Accept headers correctly, if a proxy
server MAY modify them. I don't know if that could happen, though.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/help/internals/wireprotocol.txt (13 lines)
M			mercurial/wireprotoserver.py (18 lines)
M			tests/test-http-api-httpv2.t (122 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	7013		Mar 13 2018, 9:16 PM	★	★
Diff 2	7016		Mar 13 2018, 10:49 PM	★	★
Diff 3	7138		Mar 19 2018, 7:59 PM	★	★
Diff 4	7198		Mar 21 2018, 6:19 PM	★	★
Diff 5	7226	rHG37d7a1d18b970d1ea493dc13f9fe4ce52f1dde51	Mar 13 2018, 10:44 PM	★	★

Status	Author	Revision
Closed	indygreg	D2987 stringutil: add function to pretty print an object
Closed	indygreg	D2986 wireproto: add frame flag to denote payloads as CBOR
Closed	indygreg	D2985 wireproto: implement custom __repr__ for frame
Closed	indygreg	D2984 keepalive: implement readinto()
Closed	indygreg	D2983 wireproto: port protocol handler to zope.interface
Closed	indygreg	D2982 wireproto: separate commands tables for version 1 and 2 commands
Closed	indygreg	D2981 wireproto: mark SSHv2 as a version 1 transport
Closed	indygreg	D2979 wireproto: stop aliasing wire protocol types (API)
Closed	indygreg	D2951 wireproto: use CBOR for command requests
Closed	indygreg	D2902 wireproto: define frame to represent progress updates
Closed	indygreg	D2948 wireproto: syntax for encoding CBOR into frames
Closed	indygreg	D2947 wireproto: explicit API to create outgoing streams
Closed	indygreg	D2907 wireproto: add streams to frame-based protocol
Closed	indygreg	D2906 wireproto: start to associate frame generation with a stream
Closed	indygreg	D2950 tests: fix duplicate and failing test
Closed	indygreg	D2978 cbor: import CBORDecoder and CBOREncoder
Closed	indygreg	D2949 setup: install cbor packages
Abandoned	indygreg	D2885 RFC: use Redis to cache file data
Changes Planned	indygreg	D2884 wireproto: experimental command to emit file data
Abandoned	indygreg	D2883 revlogstore: create and implement an interface for repo files storage
Closed	indygreg	D2901 wireproto: explicitly track which requests are active
Closed	indygreg	D2900 wireproto: use named arguments when passing around frame data
Closed	indygreg	D2899 wireproto: define attr-based classes for representing frames
Closed	indygreg	D2872 wireproto: define human output side channel frame
Closed	indygreg	D2871 wireproto: service multiple command requests per HTTP request
Closed	indygreg	D2870 wireproto: support for receiving multiple requests
Closed	indygreg	D2869 wireproto: add request IDs to frames
Closed	indygreg	D2860 wireproto: buffer output frames when in half duplex mode
Closed	indygreg	D2858 wireproto: define and implement responses in framing protocol
Closed	indygreg	D2857 wireproto: implement basic command dispatching for HTTPv2
Closed	indygreg	D2856 wireproto: nominally don't expose "batch" to version 2 wire transports
Closed	indygreg	D2852 wireproto: implement basic frame reading and processing
Closed	indygreg	D2851 wireproto: define and implement protocol for issuing requests
Closed	indygreg	D2868 util: prefer "bytesio" to "stringio"
Closed	indygreg	D2850 wireproto: define content negotiation for HTTPv2
Closed	indygreg	D2849 hgweb: also set Content-Type header
Closed	indygreg	D2837 wireproto: require POST for all HTTPv2 requests
Closed	indygreg	D2836 wireproto: define permissions-based routing of HTTPv2 wire protocol
Closed	indygreg	D2834 wireproto: support /api/* URL space for exposing APIs
Closed	indygreg	D2843 url: support suppressing Accept header
Closed	indygreg	D2842 util: don't log low-level I/O calls for HTTP peer
Closed	indygreg	D2841 debugcommands: support sending HTTP requests with debugwireproto
Closed	indygreg	D2726 debugcommands: support connecting to HTTP peers
Closed	indygreg	D2722 url: add HTTP handler that uses a proxied socket
Closed	indygreg	D2721 util: observable proxy objects for sockets
Closed	indygreg	D2840 hgweb: allow defining Server response header for HTTP server
Closed	indygreg	D2839 tests: use $HTTP_DATE$ for Date header
Closed	indygreg	D2720 debugcommands: introduce actions to perform deterministic reads
Closed	indygreg	D2725 httppeer: refactor how httppeer is created (API)
Closed	indygreg	D2724 httppeer: alias url as urlmod
Closed	indygreg	D2723 httppeer: consolidate _requestbuilder assignments and document
Closed	indygreg	D2832 hgweb: remove wsgirequest (API)
Closed	indygreg	D2831 hgweb: store the raw WSGI environment dict
Closed	indygreg	D2830 hgweb: remove dead wsgirequest code
Closed	indygreg	D2829 hgweb: port to new response API
Closed	indygreg	D2828 hgweb: pass modern request type into templater()
Closed	indygreg	D2827 hgweb: use modern response type for index generation
Closed	indygreg	D2826 hgweb: don't pass wsgireq to makeindex and other functions
Closed	indygreg	D2825 hgweb: replace PATH_INFO with dispatchpath
Closed	indygreg	D2824 hgweb: rewrite path generation for index entries
Closed	indygreg	D2823 hgweb: construct {url} with req.apppath
Closed	indygreg	D2822 hgweb: support constructing URLs from an alternate base URL
Closed	indygreg	D2821 hgweb: clarify that apppath begins with a forward slash
Closed	indygreg	D2820 hgweb: change how dispatch path is reported
Closed	indygreg	D2819 hgweb: refactor repository name URL parsing
Closed	indygreg	D2818 tests: add test coverage for parsing WSGI requests
Closed	indygreg	D2817 hgweb: construct static URL like hgweb does
Closed	indygreg	D2816 hgweb: remove unused **map argument
Closed	indygreg	D2815 hgweb: extract entries() to standalone function
Closed	indygreg	D2814 hgweb: move rawentries() to a standalone function
Closed	indygreg	D2813 hgweb: move archivelist to standalone function
Closed	indygreg	D2812 hgweb: move readallowed to a standalone function
Closed	indygreg	D2805 hgweb: remove some use of wsgireq in hgwebdir
Closed	indygreg	D2804 hgweb: fix a bug due to variable name typo
Closed	indygreg	D2803 hgweb: stop passing req and tmpl into @webcommand functions (API)
Closed	indygreg	D2802 hgweb: pass modern request type into various webutil functions (API)
Closed	indygreg	D2801 hgweb: don't redundantly pass templater with requestcontext (API)
Closed	indygreg	D2800 hgweb: use templater on requestcontext instance
Closed	indygreg	D2799 hgweb: add a sendtemplate() helper function
Closed	indygreg	D2798 hgweb: use web.req instead of req.req
Closed	indygreg	D2797 hgweb: stop setting headers on wsgirequest
Closed	indygreg	D2796 hgweb: always return iterable from @webcommand functions (API)
Closed	indygreg	D2795 hgweb: send errors using new response API
Closed	indygreg	D2794 hgweb: refactor 304 handling code
Closed	indygreg	D2793 hgweb: transition permissions hooks to modern request type (API)
Closed	indygreg	D2792 hgweb: port archive command to modern response API
Closed	indygreg	D2791 hgweb: refactor fake file object proxy for archiving
Closed	indygreg	D2790 tests: additional test coverage of archive web command
Closed	indygreg	D2789 hgweb: port static file handling to new response API
Closed	indygreg	D2788 hgweb: remove one-off routing for file?style=raw
Closed	indygreg	D2787 hgweb: port most @webcommand to use modern response type
Closed	indygreg	D2786 hgweb: support using new response object for web commands
Closed	indygreg	D2785 hgweb: inline caching() and port to modern mechanisms
Closed	indygreg	D2784 hgweb: expose repo name on parsedrequest
Closed	indygreg	D2783 hgweb: expose URL scheme and REMOTE_* attributes
Closed	indygreg	D2782 hgweb: remove wsgirequest.form (API)
Closed	indygreg	D2781 hgweb: perform all parameter lookup via qsparams
Closed	indygreg	D2780 hgweb: set variables in qsparams
Closed	indygreg	D2779 hgweb: use our new request object for "style" parameter
Closed	indygreg	D2776 hgweb: use a multidict for holding query string parameters
Closed	indygreg	D2775 hgweb: create dedicated type for WSGI responses
Closed	indygreg	D2778 tests: add test for a wire protocol request to wrong base URL
Closed	indygreg	D2773 hgweb: remove support for short query string based aliases (BC)
Closed	indygreg	D2774 hgweb: remove support for POST form data (BC)
Closed	indygreg	D2771 hgweb: expose input stream on parsed WSGI request object
Closed	indygreg	D2770 hgweb: make parsedrequest part of wsgirequest
Closed	indygreg	D2769 hgweb: refactor the request draining code
Closed	indygreg	D2768 hgweb: use a capped reader for WSGI input stream
Closed	indygreg	D2767 hgweb: document continuereader
Closed	indygreg	D2749 hgweb: remove wsgirequest.__iter__
Closed	indygreg	D2748 hgweb: remove wsgirequest.read()
Closed	indygreg	D2747 hgweb: remove unused methods on wsgirequest
Closed	indygreg	D2746 wireprotoserver: remove unused argument from _handlehttperror()
Closed	indygreg	D2745 hgweb: store and use request method on parsed request
Closed	indygreg	D2744 hgweb: handle CONTENT_LENGTH
Closed	indygreg	D2743 wireprotoserver: access headers through parsed request
Closed	indygreg	D2742 hgweb: parse and store HTTP request headers
Closed	indygreg	D2741 wireprotoserver: remove broken optimization for non-httplib client
Closed	indygreg	D2740 wireprotoserver: move all wire protocol handling logic out of hgweb
Closed	indygreg	D2739 hgweb: use parsed request to construct query parameters
Closed	indygreg	D2738 hgweb: only recognize wire protocol commands from query string (BC)
Closed	indygreg	D2737 hgweb: teach WSGI parser about query strings
Closed	indygreg	D2736 hgweb: use the parsed application path directly
Closed	indygreg	D2735 hgweb: use computed base URL from parsed request
Closed	indygreg	D2734 hgweb: parse WSGI request into a data structure
Closed	indygreg	D2733 hgweb: always use "?" when writing session vars
Closed	indygreg	D2732 hgweb: rename req to wsgireq
Closed	indygreg	D2731 hgweb: validate WSGI environment dict
Closed	indygreg	D2730 hgweb: ensure all wsgi environment values are str

Diff 7226

mercurial/help/internals/wireprotocol.txt

	authentication requirements are discovered upon attempting the first			authentication requirements are discovered upon attempting the first
	command - not potentially several commands into the exchange. This			command - not potentially several commands into the exchange. This
	allows clients to fail faster or prompt for credentials as soon as the			allows clients to fail faster or prompt for credentials as soon as the
	exchange takes place. This provides a better end-user experience.			exchange takes place. This provides a better end-user experience.

	Requests to unknown commands or URLS result in an HTTP 404.			Requests to unknown commands or URLS result in an HTTP 404.
	TODO formally define response type, how error is communicated, etc.			TODO formally define response type, how error is communicated, etc.

				HTTP request and response bodies use the TBD Protocol for media exchange.

				Clients and servers MUST advertise the ``TBD`` media type via the
				``Content-Type`` request and response headers. In addition, clients MUST
				advertise this media type value in their ``Accept`` request header in all
				requests.

				Servers receiving requests without an ``Accept`` header SHOULD respond with
				an HTTP 406.

				Servers receiving requests with an invalid ``Content-Type`` header SHOULD
				respond with an HTTP 415.

	SSH Protocol			SSH Protocol
	============			============

	Handshake			Handshake
	---------			---------

	For all clients, the handshake consists of the client sending 1 or more			For all clients, the handshake consists of the client sending 1 or more
	commands to the server using version 1 of the transport. Servers respond			commands to the server using version 1 of the transport. Servers respond

mercurial/wireprotoserver.py

	urlerr = util.urlerr			urlerr = util.urlerr
	urlreq = util.urlreq			urlreq = util.urlreq

	HTTP_OK = 200			HTTP_OK = 200

	HGTYPE = 'application/mercurial-0.1'			HGTYPE = 'application/mercurial-0.1'
	HGTYPE2 = 'application/mercurial-0.2'			HGTYPE2 = 'application/mercurial-0.2'
	HGERRTYPE = 'application/hg-error'			HGERRTYPE = 'application/hg-error'
				HTTPV2TYPE = 'application/mercurial-tbd'

	HTTPV2 = wireprototypes.HTTPV2			HTTPV2 = wireprototypes.HTTPV2
	SSHV1 = wireprototypes.SSHV1			SSHV1 = wireprototypes.SSHV1
	SSHV2 = wireprototypes.SSHV2			SSHV2 = wireprototypes.SSHV2

	def decodevaluefromheaders(req, headerprefix):			def decodevaluefromheaders(req, headerprefix):
	"""Decode a long value from multiple HTTP request headers.			"""Decode a long value from multiple HTTP request headers.

	proto = httpv2protocolhandler(req, ui)			proto = httpv2protocolhandler(req, ui)

	if not wireproto.commands.commandavailable(command, proto):			if not wireproto.commands.commandavailable(command, proto):
	res.status = b'404 Not Found'			res.status = b'404 Not Found'
	res.headers[b'Content-Type'] = b'text/plain'			res.headers[b'Content-Type'] = b'text/plain'
	res.setbodybytes(_('invalid wire protocol command: %s') % command)			res.setbodybytes(_('invalid wire protocol command: %s') % command)
	return			return

				if req.headers.get(b'Accept') != HTTPV2TYPE:
				res.status = b'406 Not Acceptable'
				res.headers[b'Content-Type'] = b'text/plain'
				res.setbodybytes(_('client MUST specify Accept header with value: %s\n')
				% HTTPV2TYPE)
				return

				if (b'Content-Type' in req.headers
				and req.headers[b'Content-Type'] != HTTPV2TYPE):
				res.status = b'415 Unsupported Media Type'
				# TODO we should send a response with appropriate media type,
				# since client does Accept it.
				res.headers[b'Content-Type'] = b'text/plain'
				res.setbodybytes(_('client MUST send Content-Type header with '
				'value: %s\n') % HTTPV2TYPE)
				return

	# We don't do anything meaningful yet.			# We don't do anything meaningful yet.
	res.status = b'200 OK'			res.status = b'200 OK'
	res.headers[b'Content-Type'] = b'text/plain'			res.headers[b'Content-Type'] = b'text/plain'
	res.setbodybytes(b'/'.join(urlparts) + b'\n')			res.setbodybytes(b'/'.join(urlparts) + b'\n')

	# Maps API name to metadata so custom API can be registered.			# Maps API name to metadata so custom API can be registered.
	API_HANDLERS = {			API_HANDLERS = {
	HTTPV2: {			HTTPV2: {

tests/test-http-api-httpv2.t

	$ HTTPV2=exp-http-v2-0001			$ HTTPV2=exp-http-v2-0001
				$ MEDIATYPE=application/mercurial-tbd

	$ send() {			$ send() {
	> hg --verbose debugwireproto --peer raw http://$LOCALIP:$HGPORT/			> hg --verbose debugwireproto --peer raw http://$LOCALIP:$HGPORT/
	> }			> }

	$ cat > dummycommands.py << EOF			$ cat > dummycommands.py << EOF
	> from mercurial import wireprototypes, wireproto			> from mercurial import wireprototypes, wireproto
	> @wireproto.wireprotocommand('customreadonly', permission='pull')			> @wireproto.wireprotocommand('customreadonly', permission='pull')
	> [experimental]			> [experimental]
	> web.apiserver = true			> web.apiserver = true
	> web.api.http-v2 = true			> web.api.http-v2 = true
	> EOF			> EOF

	$ hg -R server serve -p $HGPORT -d --pid-file hg.pid			$ hg -R server serve -p $HGPORT -d --pid-file hg.pid
	$ cat hg.pid > $DAEMON_PIDS			$ cat hg.pid > $DAEMON_PIDS

	Request to read-only command works out of the box			Request to unknown command yields 404

				$ send << EOF
				> httprequest POST api/$HTTPV2/ro/badcommand
				> user-agent: test
				> EOF
				using raw connection to peer
				s> POST /api/exp-http-v2-0001/ro/badcommand HTTP/1.1\r\n
				s> Accept-Encoding: identity\r\n
				s> user-agent: test\r\n
				s> host: $LOCALIP:$HGPORT\r\n (glob)
				s> \r\n
				s> makefile('rb', None)
				s> HTTP/1.1 404 Not Found\r\n
				s> Server: testing stub value\r\n
				s> Date: $HTTP_DATE$\r\n
				s> Content-Type: text/plain\r\n
				s> Content-Length: 42\r\n
				s> \r\n
				s> unknown wire protocol command: badcommand\n

				GET to read-only command yields a 405

				$ send << EOF
				> httprequest GET api/$HTTPV2/ro/customreadonly
				> user-agent: test
				> EOF
				using raw connection to peer
				s> GET /api/exp-http-v2-0001/ro/customreadonly HTTP/1.1\r\n
				s> Accept-Encoding: identity\r\n
				s> user-agent: test\r\n
				s> host: $LOCALIP:$HGPORT\r\n (glob)
				s> \r\n
				s> makefile('rb', None)
				s> HTTP/1.1 405 Method Not Allowed\r\n
				s> Server: testing stub value\r\n
				s> Date: $HTTP_DATE$\r\n
				s> Allow: POST\r\n
				s> Content-Length: 30\r\n
				s> \r\n
				s> commands require POST requests

				Missing Accept header results in 406

	$ send << EOF			$ send << EOF
	> httprequest POST api/$HTTPV2/ro/customreadonly			> httprequest POST api/$HTTPV2/ro/customreadonly
	> user-agent: test			> user-agent: test
	> EOF			> EOF
	using raw connection to peer			using raw connection to peer
	s> POST /api/exp-http-v2-0001/ro/customreadonly HTTP/1.1\r\n			s> POST /api/exp-http-v2-0001/ro/customreadonly HTTP/1.1\r\n
	s> Accept-Encoding: identity\r\n			s> Accept-Encoding: identity\r\n
	s> user-agent: test\r\n			s> user-agent: test\r\n
	s> host: $LOCALIP:$HGPORT\r\n (glob)			s> host: $LOCALIP:$HGPORT\r\n (glob)
	s> \r\n			s> \r\n
	s> makefile('rb', None)			s> makefile('rb', None)
	s> HTTP/1.1 200 OK\r\n			s> HTTP/1.1 406 Not Acceptable\r\n
	s> Server: testing stub value\r\n			s> Server: testing stub value\r\n
	s> Date: $HTTP_DATE$\r\n			s> Date: $HTTP_DATE$\r\n
	s> Content-Type: text/plain\r\n			s> Content-Type: text/plain\r\n
	s> Content-Length: 18\r\n			s> Content-Length: 72\r\n
	s> \r\n			s> \r\n
	s> ro/customreadonly\n			s> client MUST specify Accept header with value: application/mercurial-tbd\n

	Request to unknown command yields 404			Bad Accept header results in 406

	$ send << EOF			$ send << EOF
	> httprequest POST api/$HTTPV2/ro/badcommand			> httprequest POST api/$HTTPV2/ro/customreadonly
				> accept: invalid
	> user-agent: test			> user-agent: test
	> EOF			> EOF
	using raw connection to peer			using raw connection to peer
	s> POST /api/exp-http-v2-0001/ro/badcommand HTTP/1.1\r\n			s> POST /api/exp-http-v2-0001/ro/customreadonly HTTP/1.1\r\n
	s> Accept-Encoding: identity\r\n			s> Accept-Encoding: identity\r\n
				s> accept: invalid\r\n
	s> user-agent: test\r\n			s> user-agent: test\r\n
	s> host: $LOCALIP:$HGPORT\r\n (glob)			s> host: $LOCALIP:$HGPORT\r\n (glob)
	s> \r\n			s> \r\n
	s> makefile('rb', None)			s> makefile('rb', None)
	s> HTTP/1.1 404 Not Found\r\n			s> HTTP/1.1 406 Not Acceptable\r\n
	s> Server: testing stub value\r\n			s> Server: testing stub value\r\n
	s> Date: $HTTP_DATE$\r\n			s> Date: $HTTP_DATE$\r\n
	s> Content-Type: text/plain\r\n			s> Content-Type: text/plain\r\n
	s> Content-Length: 42\r\n			s> Content-Length: 72\r\n
	s> \r\n			s> \r\n
	s> unknown wire protocol command: badcommand\n			s> client MUST specify Accept header with value: application/mercurial-tbd\n

	GET to read-only command yields a 405			Bad Content-Type header results in 415

	$ send << EOF			$ send << EOF
	> httprequest GET api/$HTTPV2/ro/customreadonly			> httprequest POST api/$HTTPV2/ro/customreadonly
				> accept: $MEDIATYPE
	> user-agent: test			> user-agent: test
				> content-type: badmedia
	> EOF			> EOF
	using raw connection to peer			using raw connection to peer
	s> GET /api/exp-http-v2-0001/ro/customreadonly HTTP/1.1\r\n			s> POST /api/exp-http-v2-0001/ro/customreadonly HTTP/1.1\r\n
	s> Accept-Encoding: identity\r\n			s> Accept-Encoding: identity\r\n
				s> accept: application/mercurial-tbd\r\n
				s> content-type: badmedia\r\n
	s> user-agent: test\r\n			s> user-agent: test\r\n
	s> host: $LOCALIP:$HGPORT\r\n (glob)			s> host: $LOCALIP:$HGPORT\r\n (glob)
	s> \r\n			s> \r\n
	s> makefile('rb', None)			s> makefile('rb', None)
	s> HTTP/1.1 405 Method Not Allowed\r\n			s> HTTP/1.1 415 Unsupported Media Type\r\n
	s> Server: testing stub value\r\n			s> Server: testing stub value\r\n
	s> Date: $HTTP_DATE$\r\n			s> Date: $HTTP_DATE$\r\n
	s> Allow: POST\r\n			s> Content-Type: text/plain\r\n
	s> Content-Length: 30\r\n			s> Content-Length: 75\r\n
	s> \r\n			s> \r\n
	s> commands require POST requests			s> client MUST send Content-Type header with value: application/mercurial-tbd\n

				Request to read-only command works out of the box

				$ send << EOF
				> httprequest POST api/$HTTPV2/ro/customreadonly
				> accept: $MEDIATYPE
				> content-type: $MEDIATYPE
				> user-agent: test
				> EOF
				using raw connection to peer
				s> POST /api/exp-http-v2-0001/ro/customreadonly HTTP/1.1\r\n
				s> Accept-Encoding: identity\r\n
				s> accept: application/mercurial-tbd\r\n
				s> content-type: application/mercurial-tbd\r\n
				s> user-agent: test\r\n
				s> host: $LOCALIP:$HGPORT\r\n (glob)
				s> \r\n
				s> makefile('rb', None)
				s> HTTP/1.1 200 OK\r\n
				s> Server: testing stub value\r\n
				s> Date: $HTTP_DATE$\r\n
				s> Content-Type: text/plain\r\n
				s> Content-Length: 18\r\n
				s> \r\n
				s> ro/customreadonly\n

	Request to read-write command fails because server is read-only by default			Request to read-write command fails because server is read-only by default

	GET to read-write request yields 405			GET to read-write request yields 405

	$ send << EOF			$ send << EOF
	> httprequest GET api/$HTTPV2/rw/customreadonly			> httprequest GET api/$HTTPV2/rw/customreadonly
	> user-agent: test			> user-agent: test
	$ hg -R server serve -p $HGPORT -d --pid-file hg.pid			$ hg -R server serve -p $HGPORT -d --pid-file hg.pid
	$ cat hg.pid > $DAEMON_PIDS			$ cat hg.pid > $DAEMON_PIDS

	Authorized request for valid read-write command works			Authorized request for valid read-write command works

	$ send << EOF			$ send << EOF
	> httprequest POST api/$HTTPV2/rw/customreadonly			> httprequest POST api/$HTTPV2/rw/customreadonly
	> user-agent: test			> user-agent: test
				> accept: $MEDIATYPE
				> content-type: $MEDIATYPE
	> EOF			> EOF
	using raw connection to peer			using raw connection to peer
	s> POST /api/exp-http-v2-0001/rw/customreadonly HTTP/1.1\r\n			s> POST /api/exp-http-v2-0001/rw/customreadonly HTTP/1.1\r\n
	s> Accept-Encoding: identity\r\n			s> Accept-Encoding: identity\r\n
				s> accept: application/mercurial-tbd\r\n
				s> content-type: application/mercurial-tbd\r\n
	s> user-agent: test\r\n			s> user-agent: test\r\n
	s> host: $LOCALIP:$HGPORT\r\n (glob)			s> host: $LOCALIP:$HGPORT\r\n (glob)
	s> \r\n			s> \r\n
	s> makefile('rb', None)			s> makefile('rb', None)
	s> HTTP/1.1 200 OK\r\n			s> HTTP/1.1 200 OK\r\n
	s> Server: testing stub value\r\n			s> Server: testing stub value\r\n
	s> Date: $HTTP_DATE$\r\n			s> Date: $HTTP_DATE$\r\n
	s> Content-Type: text/plain\r\n			s> Content-Type: text/plain\r\n
	s> Content-Length: 18\r\n			s> Content-Length: 18\r\n
	s> \r\n			s> \r\n
	s> rw/customreadonly\n			s> rw/customreadonly\n

	Authorized request for unknown command is rejected			Authorized request for unknown command is rejected

	$ send << EOF			$ send << EOF
	> httprequest POST api/$HTTPV2/rw/badcommand			> httprequest POST api/$HTTPV2/rw/badcommand
	> user-agent: test			> user-agent: test
				> accept: $MEDIATYPE
	> EOF			> EOF
	using raw connection to peer			using raw connection to peer
	s> POST /api/exp-http-v2-0001/rw/badcommand HTTP/1.1\r\n			s> POST /api/exp-http-v2-0001/rw/badcommand HTTP/1.1\r\n
	s> Accept-Encoding: identity\r\n			s> Accept-Encoding: identity\r\n
				s> accept: application/mercurial-tbd\r\n
	s> user-agent: test\r\n			s> user-agent: test\r\n
	s> host: $LOCALIP:$HGPORT\r\n (glob)			s> host: $LOCALIP:$HGPORT\r\n (glob)
	s> \r\n			s> \r\n
	s> makefile('rb', None)			s> makefile('rb', None)
	s> HTTP/1.1 404 Not Found\r\n			s> HTTP/1.1 404 Not Found\r\n
	s> Server: testing stub value\r\n			s> Server: testing stub value\r\n
	s> Date: $HTTP_DATE$\r\n			s> Date: $HTTP_DATE$\r\n
	s> Content-Type: text/plain\r\n			s> Content-Type: text/plain\r\n
	s> Content-Length: 42\r\n			s> Content-Length: 42\r\n
	s> \r\n			s> \r\n
	s> unknown wire protocol command: badcommand\n			s> unknown wire protocol command: badcommand\n

This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: define content negotiation for HTTPv2ClosedPublic