This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	durin42	D7406 scmutil: convert status data object from a tuple to an attrs (API)
Closed	durin42	D7405 perf: bool() elements of dirstate.status return instead of len()
Closed	durin42	D7404 tags: use field names instead of field numbers on scmutil.status
Closed	durin42	D7403 subrepo: use field names instead of field numbers on scmutil.status
Closed	durin42	D7402 revset: use field names instead of field numbers on scmutil.status
Closed	durin42	D7401 patch: use field names instead of field numbers on scmutil.status
Closed	durin42	D7400 logcmdutil: use field names instead of field numbers on scmutil.status
Closed	durin42	D7399 context: use field names instead of field numbers on scmutil.status
Closed	durin42	D7398 commands: use field names instead of field numbers on scmutil.status
Closed	durin42	D7397 cmdutil: convert terse status result back to an scmutil.status
Closed	durin42	D7396 cmdutil: use field names instead of field numbers on scmutil.status
Closed	durin42	D7395 uncommit: use field names instead of field numbers on scmutil.status
Closed	durin42	D7394 transplant: use field names instead of field numbers on scmutil.status
Closed	durin42	D7393 split: use field names instead of field numbers on scmutil.status
Closed	durin42	D7392 mq: use field names instead of field numbers on scmutil.status
Closed	durin42	D7391 hgk: use field names instead of field numbers on scmutil.status
Closed	durin42	D7390 extdiff: use field names instead of field numbers on scmutil.status
Closed	durin42	D7294 cmdutil: suppress bogus pytype errors
Closed	durin42	D7293 changegroup: suppress pytype error that's wrong
Closed	durin42	D7292 changegroup: avoid shadowing a set with an int
Closed	durin42	D7291 bundle2: more pytype suppressions around bytestring
Closed	durin42	D7290 branchmap: pytype is confused about bytestr
Closed	durin42	D7383 state: add a pytype annotation
Closed	durin42	D7382 logcmdutil: add a type annotation
Closed	durin42	D7381 cmdutil: add a pytype annotation to help out some callsites
Abandoned	durin42	D7297 cleanup: remove now-obsolete wrong-arg-type annotations
Abandoned	durin42	D7380 encoding: define per-use identity functions only in typechecking mode
Changes Planned	mharbison72	D7515 pytype: [WIP] suppress various warnings inline to get a clean run
Needs Revision	durin42	D7295 pytype: add a (very slow) test that executes pytype
Closed	durin42	D7410 extensions: suppress a pytype failure due to a typeshed bug
Closed	durin42	D7409 dispatch: add some assertions to give pytype a helping hand
Closed	durin42	D7408 extensions: hide two confusing import statements from pytype
Closed	durin42	D7407 debugcommands: add assertions to convince pytype peer is not None
Closed	durin42	D7385 debugcommands: suppress import errors for pytype
Needs Revision	durin42	D7384 commands: necessary annotations and suppresssions to pass pytype
Changes Planned	durin42	D7296 pycompat: kludge around pytype being confused by __new__
Closed	durin42	D7379 encoding: fix bad type annotation
Closed	durin42	D7389 branchmap: annotate constructor type for branchcache
Closed	durin42	D7378 debugcommands: don't shadow the error module
Closed	durin42	D7289 branchmap: correctly set()-ify list argument

Diff 18102

mercurial/dispatch.py

	try:			try:
	status = dispatch(req)			status = dispatch(req)
	except error.StdioError as e:			except error.StdioError as e:
	err = e			err = e
	status = -1			status = -1

	# In all cases we try to flush stdio streams.			# In all cases we try to flush stdio streams.
	if util.safehasattr(req.ui, b'fout'):			if util.safehasattr(req.ui, b'fout'):
				assert req.ui is not None # help pytype
				assert req.ui.fout is not None # help pytype
	try:			try:
	req.ui.fout.flush()			req.ui.fout.flush()
	except IOError as e:			except IOError as e:
	err = e			err = e
	status = -1			status = -1

	if util.safehasattr(req.ui, b'ferr'):			if util.safehasattr(req.ui, b'ferr'):
				assert req.ui is not None # help pytype
				assert req.ui.ferr is not None # help pytype
	try:			try:
	if err is not None and err.errno != errno.EPIPE:			if err is not None and err.errno != errno.EPIPE:
	req.ui.ferr.write(			req.ui.ferr.write(
	b'abort: %s\n' % encoding.strtolocal(err.strerror)			b'abort: %s\n' % encoding.strtolocal(err.strerror)
	)			)
	req.ui.ferr.flush()			req.ui.ferr.flush()
	# There's not much we can do about an I/O error here. So (possibly)			# There's not much we can do about an I/O error here. So (possibly)
	# change the status code and move on.			# change the status code and move on.
	return commands.version_(ui)			return commands.version_(ui)
	if options[b'help']:			if options[b'help']:
	return commands.help_(ui, cmd, command=cmd is not None)			return commands.help_(ui, cmd, command=cmd is not None)
	elif not cmd:			elif not cmd:
	return commands.help_(ui, b'shortlist')			return commands.help_(ui, b'shortlist')

	repo = None			repo = None
	cmdpats = args[:]			cmdpats = args[:]
				assert func is not None # help out pytype
	if not func.norepo:			if not func.norepo:
	# use the repo from the request only if we don't have -R			# use the repo from the request only if we don't have -R
	if not rpath and not cwd:			if not rpath and not cwd:
	repo = req.repo			repo = req.repo

	if repo:			if repo:
	# set the descriptors of the repo ui to those of ui			# set the descriptors of the repo ui to those of ui
	repo.ui.fin = ui.fin			repo.ui.fin = ui.fin

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	18102		Nov 14 2019, 4:10 PM	★	★
Diff 2	18229	rHGac8fd215a776b423d27720d6f0124d7f5e2d6a66	Nov 14 2019, 3:49 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

dispatch: add some assertions to give pytype a helping handClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18102

mercurial/dispatch.py

dispatch: add some assertions to give pytype a helping hand
ClosedPublic

Revision Contents
Changeset List