( )⚙ D9483 upgrade: gather code about source checking together

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9483

upgrade: gather code about source checking together
ClosedPublic

Authored by marmoute on Dec 1 2020, 5:11 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa2a59cde9b9f: upgrade: gather code about source checking together
Summary

They just moved in the same file, now they are grouped together and documented.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Dec 1 2020, 5:11 PM
baymax updated this revision to Diff 24034.Dec 4 2020, 6:47 PM
pulkit accepted this revision.Dec 6 2020, 6:08 AM
This revision is now accepted and ready to land.Dec 6 2020, 6:08 AM
marmoute added a commit: rHGa2a59cde9b9f: upgrade: gather code about source checking together.Dec 6 2020, 7:15 AM
Closed by commit rHGa2a59cde9b9f: upgrade: gather code about source checking together (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade_utils/actions.py (67 lines)

Diff 24034

mercurial/upgrade_utils/actions.py

# list of requirements that request a clone of all revlog if added/removed # list of requirements that request a clone of all revlog if added/removed
RECLONES_REQUIREMENTS = { RECLONES_REQUIREMENTS = {
b'generaldelta', b'generaldelta',
requirements.SPARSEREVLOG_REQUIREMENT, requirements.SPARSEREVLOG_REQUIREMENT,
} }
def requiredsourcerequirements(repo):
"""Obtain requirements required to be present to upgrade a repo.
An upgrade will not be allowed if the repository doesn't have the
requirements returned by this function.
"""
return {
# Introduced in Mercurial 0.9.2.
b'revlogv1',
# Introduced in Mercurial 0.9.2.
b'store',
}
def blocksourcerequirements(repo):
"""Obtain requirements that will prevent an upgrade from occurring.
An upgrade cannot be performed if the source repository contains a
requirements in the returned set.
"""
return {
# The upgrade code does not yet support these experimental features.
# This is an artificial limitation.
requirements.TREEMANIFEST_REQUIREMENT,
# This was a precursor to generaldelta and was never enabled by default.
# It should (hopefully) not exist in the wild.
b'parentdelta',
# Upgrade should operate on the actual store, not the shared link.
requirements.SHARED_REQUIREMENT,
}
def supportremovedrequirements(repo): def supportremovedrequirements(repo):
"""Obtain requirements that can be removed during an upgrade. """Obtain requirements that can be removed during an upgrade.
If an upgrade were to create a repository that dropped a requirement, If an upgrade were to create a repository that dropped a requirement,
the dropped requirement must appear in the returned set for the upgrade the dropped requirement must appear in the returned set for the upgrade
to be allowed. to be allowed.
""" """
supported = { supported = {
newactions.append(d) newactions.append(d)
# FUTURE consider adding some optimizations here for certain transitions. # FUTURE consider adding some optimizations here for certain transitions.
# e.g. adding generaldelta could schedule parent redeltas. # e.g. adding generaldelta could schedule parent redeltas.
return newactions return newactions
### Code checking if a repository can got through the upgrade process at all. #
def requiredsourcerequirements(repo):
"""Obtain requirements required to be present to upgrade a repo.
An upgrade will not be allowed if the repository doesn't have the
requirements returned by this function.
"""
return {
# Introduced in Mercurial 0.9.2.
b'revlogv1',
# Introduced in Mercurial 0.9.2.
b'store',
}
def blocksourcerequirements(repo):
"""Obtain requirements that will prevent an upgrade from occurring.
An upgrade cannot be performed if the source repository contains a
requirements in the returned set.
"""
return {
# The upgrade code does not yet support these experimental features.
# This is an artificial limitation.
requirements.TREEMANIFEST_REQUIREMENT,
# This was a precursor to generaldelta and was never enabled by default.
# It should (hopefully) not exist in the wild.
b'parentdelta',
# Upgrade should operate on the actual store, not the shared link.
requirements.SHARED_REQUIREMENT,
}
def check_source_requirements(repo): def check_source_requirements(repo):
"""Ensure that no existing requirements prevent the repository upgrade""" """Ensure that no existing requirements prevent the repository upgrade"""
required = requiredsourcerequirements(repo) required = requiredsourcerequirements(repo)
missingreqs = required - repo.requirements missingreqs = required - repo.requirements
if missingreqs: if missingreqs:
msg = _(b'cannot upgrade repository; requirement missing: %s') msg = _(b'cannot upgrade repository; requirement missing: %s')
missingreqs = b', '.join(sorted(missingreqs)) missingreqs = b', '.join(sorted(missingreqs))
raise error.Abort(msg % missingreqs) raise error.Abort(msg % missingreqs)
blocking = blocksourcerequirements(repo) blocking = blocksourcerequirements(repo)
blockingreqs = blocking & repo.requirements blockingreqs = blocking & repo.requirements
if blockingreqs: if blockingreqs:
m = _(b'cannot upgrade repository; unsupported source requirement: %s') m = _(b'cannot upgrade repository; unsupported source requirement: %s')
blockingreqs = b', '.join(sorted(blockingreqs)) blockingreqs = b', '.join(sorted(blockingreqs))
raise error.Abort(m % blockingreqs) raise error.Abort(m % blockingreqs)