This is an archive of the discontinued Mercurial Phabricator instance.

This appears to break histedit tests for me somehow, which is curious because I swear they passed once. I'll drop it for now and try to come back to it.

durin42 mentioned this in D2240: histedit: convert bool to bytestring manually.Feb 13 2018, 11:56 PM

Revision Contents
Changeset List

			Path	Packages
M			hgext/histedit.py (2 lines)

Status	Author	Revision
Closed	indygreg	D2151 py3: check for bytes instead of str in hg.share()
Closed	indygreg	D2150 py3: port metaedit extension to Python 3
Closed	indygreg	D2149 py3: pass system string to email.message.Message.set_type()
Closed	indygreg	D2148 py3: open temporary file in binary mode
Closed	indygreg	D2147 py3: use email parser that operates on bytes
Closed	indygreg	D2176 py3: convert traceback representation to bytes when logging
Closed	indygreg	D2175 py3: use b'' in mockblackbox.py
Closed	indygreg	D2174 py3: convert context to bytes instead of str
Closed	indygreg	D2173 py3: add missing b'' literal to sshprotoext.py
Closed	indygreg	D2172 py3: convert FrameInfo members to bytes
Closed	indygreg	D2171 ui: use named attributes on FrameInfo instance
Closed	indygreg	D2170 py3: make dummyssh compatible with Python 3
Closed	indygreg	D2169 py3: explicitly cast bool to bytes
Closed	indygreg	D2168 mail: import email.utils not email.Utils
Closed	indygreg	D2167 py3: cast character set to bytes
Closed	indygreg	D2166 py3: cast decode() argument to system string
Closed	indygreg	D2165 githelp: cast commands to bytes
Closed	indygreg	D2164 py3: avoid changing dictionary during iteration
Closed	indygreg	D2163 py3: use raw string for key in **kwargs
Closed	indygreg	D2162 py3: preserve chunks as an iterable of bytes
Closed	indygreg	D2161 py3: use b'' for changegroup version literals
Closed	indygreg	D2160 py3: use b'' in inline extension
Closed	indygreg	D2159 py3: use hex(hasher.digest())
Needs Revision	indygreg	D2158 py3: use raw string for open() mode
Closed	indygreg	D2157 py3: use string for "close" value in commit extras
Closed	indygreg	D2156 py3: catch TypeError during template operations
Closed	indygreg	D2155 py3: use bytes literals for test extension
Closed	indygreg	D2154 py3: use system strings when calling __import__
Closed	indygreg	D2153 py3: open patches.queue in binary mode
Closed	indygreg	D2152 py3: compare against bytes instead of str
Closed	indygreg	D2146 py3: port string formatting
Closed	indygreg	D2145 py3: port ext-phase-report.py extension
Closed	indygreg	D2144 py3: more robustly cast UUID to bytes
Closed	indygreg	D2143 py3: use bytes() to cast context instances
Closed	indygreg	D2142 py3: convert __doc__ to bytes
Closed	indygreg	D2141 py3: cast repr() result to bytes
Closed	indygreg	D2140 py3: fix file i/o in test-status.t
Closed	indygreg	D2139 py3: pass system string to socket.getservbyname
Closed	indygreg	D2138 run-tests: report tests that exception occurred in
Closed	indygreg	D2137 py3: use raw string for file open mode
Closed	indygreg	D2136 py3: convert content-type to bytes

Diff 5470

hgext/histedit.py

	else:			else:
	with self.repo.vfs("histedit-state", "w") as f:			with self.repo.vfs("histedit-state", "w") as f:
	self._write(f)			self._write(f)

	def _write(self, fp):			def _write(self, fp):
	fp.write('v1\n')			fp.write('v1\n')
	fp.write('%s\n' % node.hex(self.parentctxnode))			fp.write('%s\n' % node.hex(self.parentctxnode))
	fp.write('%s\n' % node.hex(self.topmost))			fp.write('%s\n' % node.hex(self.topmost))
	fp.write('%s\n' % self.keep)			fp.write('%s\n' % 'True' if self.keep else 'False')
	fp.write('%d\n' % len(self.actions))			fp.write('%d\n' % len(self.actions))
	for action in self.actions:			for action in self.actions:
	fp.write('%s\n' % action.tostate())			fp.write('%s\n' % action.tostate())
	fp.write('%d\n' % len(self.replacements))			fp.write('%d\n' % len(self.replacements))
	for replacement in self.replacements:			for replacement in self.replacements:
	fp.write('%s%s\n' % (node.hex(replacement[0]), ''.join(node.hex(r)			fp.write('%s%s\n' % (node.hex(replacement[0]), ''.join(node.hex(r)
	for r in replacement[1])))			for r in replacement[1])))
	backupfile = self.backupfile			backupfile = self.backupfile

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	5470		Feb 11 2018, 10:45 PM	★	★
Diff 2	5592	rHGd78a5198226250254194b6160c24e94414ad3b19	Feb 11 2018, 10:02 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

py3: explicitly cast bool to bytesClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5470

hgext/histedit.py

py3: explicitly cast bool to bytes
ClosedPublic

Revision Contents
Changeset List