This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2169

py3: explicitly cast bool to bytes
ClosedPublic

Authored by indygreg on Feb 11 2018, 10:45 PM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd78a51982262: py3: explicitly cast bool to bytes
Summary

Yes, the file format actually looks for literal True.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 10:45 PM
pulkit accepted this revision.Feb 12 2018, 2:44 AM
durin42 accepted this revision.Feb 12 2018, 9:32 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:32 PM
Closed by commit rHGd78a51982262: py3: explicitly cast bool to bytes (authored by indygreg). · Explain WhyFeb 12 2018, 9:48 PM
This revision was automatically updated to reflect the committed changes.
durin42 added a comment.Feb 12 2018, 10:09 PM

This appears to break histedit tests for me somehow, which is curious because I swear they passed once. I'll drop it for now and try to come back to it.

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (2 lines)

Diff 5592

hgext/histedit.py

else: else:
with self.repo.vfs("histedit-state", "w") as f: with self.repo.vfs("histedit-state", "w") as f:
self._write(f) self._write(f)
def _write(self, fp): def _write(self, fp):
fp.write('v1\n') fp.write('v1\n')
fp.write('%s\n' % node.hex(self.parentctxnode)) fp.write('%s\n' % node.hex(self.parentctxnode))
fp.write('%s\n' % node.hex(self.topmost)) fp.write('%s\n' % node.hex(self.topmost))
fp.write('%s\n' % self.keep) fp.write('%s\n' % 'True' if self.keep else 'False')
fp.write('%d\n' % len(self.actions)) fp.write('%d\n' % len(self.actions))
for action in self.actions: for action in self.actions:
fp.write('%s\n' % action.tostate()) fp.write('%s\n' % action.tostate())
fp.write('%d\n' % len(self.replacements)) fp.write('%d\n' % len(self.replacements))
for replacement in self.replacements: for replacement in self.replacements:
fp.write('%s%s\n' % (node.hex(replacement[0]), ''.join(node.hex(r) fp.write('%s%s\n' % (node.hex(replacement[0]), ''.join(node.hex(r)
for r in replacement[1]))) for r in replacement[1])))
backupfile = self.backupfile backupfile = self.backupfile